Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config for holiday feature and student model #3204

Merged
merged 4 commits into from Dec 30, 2018
Merged

Config for holiday feature and student model #3204

merged 4 commits into from Dec 30, 2018

Conversation

Raycoms
Copy link
Contributor

@Raycoms Raycoms commented Dec 29, 2018

Changes proposed in this pull request:

  • Add male student model (monk).
  • Add config option to turn off holidays features.

Review please

@ldtteam ldtteam deleted a comment Dec 29, 2018
@ldtteam ldtteam deleted a comment Dec 29, 2018
marchermans
marchermans previously approved these changes Dec 29, 2018
View reviewed changes
@ldtteam ldtteam deleted a comment Dec 30, 2018
@Raycoms Raycoms merged commit 8a68e22 into version/1.12 Dec 30, 2018
@Raycoms Raycoms deleted the feature/student-model branch December 30, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchermans marchermans marchermans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Raycoms @marchermans